perf(net): P2P sink, revert pull/11658 #11712
Conversation
emhane
added
C-perf
| let poll_res = loop { | ||
| match this.inner.as_mut().poll_ready(cx) { |
There was a problem hiding this comment.
this loop is actually redundant.
as described in the issue I'd like to solve this differently, because this currently also doesn't really make use of the framed buffer, so I don't really want to revert this again but improve it instead
There was a problem hiding this comment.
I don't see how it doesn't make use of the framed buffer?
There was a problem hiding this comment.
Framed wraps FramedImpl
https://docs.rs/tokio-util/latest/src/tokio_util/codec/framed.rs.html#17-41
this is how FramedImpl implements poll_ready, it flushes if enough messages are buffered to fill a frame
https://docs.rs/tokio-util/latest/src/tokio_util/codec/framed_impl.rs.html#261-267
poll_flush impl for P2PStream, calls poll_flush on framed explicitly before returning to make sure all messages are sent. this last frame may be partly full.
Closes #11677
Reverts #11658