chore(sdk): add helper trait to node API to simplify type definition #10616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
mattsse,
Rjected,
fgimenez and
onbjerg
as code owners
github-actions
bot
added
S-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9555
Building unit tests for any type that inherits from
FullNodeComponentsis too costly. Replacing the trait boundN: FullNodeComponentswithN: NodeCorein type definitions, enables testing without importing a massive framework of unused mock node components. This, without scarfing the aggregate genericNfor a long list of generics and with it DevX.reth_node_api::NodeCoreandreth_node_api::NodeTy, with blanket implementation for all types that implreth_node_api::FullNodeComponentsandreth_node_api::NodeTypesrespectively.reth_optimism_rpc::OpEthApi<N: FullNodeComponents>withOpEthApi<N: NodeCore>