Skip to content

Make gas_limit setting an option #16158

Closed
@mattsse

Description

@mattsse

Describe the feature

we need to distinguish between default and custom setting, hence we need to make this value an option

##TODO

convert this into an option:

/// Target gas limit for built blocks.
#[arg(long = "builder.gaslimit", default_value_t = ETHEREUM_BLOCK_GAS_LIMIT_36M, value_name = "GAS_LIMIT")]
pub gas_limit: u64,

and this as well

fn gas_limit(&self) -> u64;

this can use unwrap_or

EthereumBuilderConfig::new().with_gas_limit(conf.gas_limit()),

with

gas_limit: ETHEREUM_BLOCK_GAS_LIMIT_36M,

Additional context

No response

Metadata

Metadata

Assignees

Labels

C-enhancementNew feature or requestD-good-first-issueNice and easy! A great choice to get started

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions