Refactor `EthApi` generics

[emhane]

Describe the feature

Replace the list of generics for EthApi and EthApiInner with N: RpcNodeCore.

reth/crates/rpc/rpc/src/eth/core.rs

Lines 48 to 69 in a0c7d1c

	/// `Eth` API implementation.
	///
	/// This type provides the functionality for handling `eth_` related requests.
	/// These are implemented two-fold: Core functionality is implemented as
	/// [`EthApiSpec`](reth_rpc_eth_api::helpers::EthApiSpec) trait. Additionally, the required server
	/// implementations (e.g. [`EthApiServer`](reth_rpc_eth_api::EthApiServer)) are implemented
	/// separately in submodules. The rpc handler implementation can then delegate to the main impls.
	/// This way [`EthApi`] is not limited to [`jsonrpsee`] and can be used standalone or in other
	/// network handlers (for example ipc).
	///
	/// ## Trait requirements
	///
	/// While this type requires various unrestricted generic components, trait bounds are enforced when
	/// additional traits are implemented for this type.
	#[derive(Deref)]
	pub struct EthApi<Provider: BlockReader, Pool, Network, EvmConfig> {
	/// All nested fields bundled together.
	#[deref]
	pub(super) inner: Arc<EthApiInner<Provider, Pool, Network, EvmConfig>>,
	/// Transaction RPC response builder.
	pub tx_resp_builder: EthTxBuilder,
	}

See how it is done for OpEthApi.

Additional context

Changing EthApiInner this way appears to be the only way to workaround rustdoc bug rust-lang/rust#91380 encountered in #15508. Refactoring EthApiInner requires EthApi to be refactored too.

[emhane]

@lean-apple are you keen on this?

[lean-apple]

@lean-apple are you keen on this?

Hi Emilia 🙂 Thanks for asking, and I like the issue but I have no bandwidth before tonight.

[mattsse]

I'd like to hold off here for a bit

[github-actions]

This issue is stale because it has been open for 21 days with no activity.