Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap BlobTransactionSideCar in Arcs in txpool #11460

Open
mattsse opened this issue Oct 3, 2024 · 3 comments
Open

Wrap BlobTransactionSideCar in Arcs in txpool #11460

mattsse opened this issue Oct 3, 2024 · 3 comments
Assignees
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 3, 2024

Describe the feature

currently, we're cloning the sidecar in various places, which is pretty expensive, we also never modify these so we really should pass that around as an Arc.

this is pretty common and we should actually add a helper type like SharedBlobTransactionSidecar(Arc<BlobTransactionSidecar>) to alloy directly.

TODO

  • introduce helper type in alloy
  • transition to that type

since this type is very simple, this can also added to reth so we don't need to wait until it lands in alloy.

e.g:

fn get_all_blobs(
&self,
tx_hashes: Vec<TxHash>,
) -> Result<Vec<(TxHash, BlobTransactionSidecar)>, BlobStoreError>;

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started A-tx-pool Related to the transaction mempool and removed S-needs-triage This issue needs to be labelled labels Oct 3, 2024
@kdonthi
Copy link

kdonthi commented Oct 3, 2024

I would like to take this

@mattsse
Copy link
Collaborator Author

mattsse commented Oct 4, 2024

actually we can just use Arc<BlobTransactionSidecar> everywhere first

like we already do here:

pub sidecar: Arc<BlobTransactionSidecar>,

we still want the helper type on alloy though

@YashBit
Copy link

YashBit commented Oct 8, 2024

@mattsse I am interested in some good first issues as well. But they always seem to be taken up quickly. Any other recommendations for issues which don't have the label, but might be relatively easier to get started with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

No branches or pull requests

3 participants