Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap sidecare in arcs #11554

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Wrap sidecare in arcs #11554

wants to merge 12 commits into from

Conversation

kdonthi
Copy link

@kdonthi kdonthi commented Oct 7, 2024 •
edited by mattsse
Loading

ref #11460

mattsse
mattsse requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great already.

crates/transaction-pool/src/lib.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/blobstore/disk.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-tx-pool Related to the transaction mempool labels Oct 8, 2024
@kdonthi kdonthi marked this pull request as ready for review October 9, 2024 21:10
@kdonthi kdonthi requested a review from Rjected as a code owner October 9, 2024 21:10
@kdonthi kdonthi requested a review from mattsse October 9, 2024 21:29
mattsse
mattsse approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, lgtm

need to do one final check before merging

@mattsse
Copy link
Collaborator

mattsse commented Oct 17, 2024

does not compile yet though, looks like one function needs to be migrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdonthi @mattsse