Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path handling in CLI tool #33

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Fix path handling in CLI tool #33

merged 4 commits into from
Jul 6, 2023

Conversation

jmcph4
Copy link
Contributor

@jmcph4 jmcph4 commented Jul 5, 2023

Issue

#32

Changes

  • Use the path API provided by the standard library in the generator crate
  • Add bin/cli to the default members list in the main Cargo manifest

FrankieIsLost
FrankieIsLost approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@FrankieIsLost FrankieIsLost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankieIsLost FrankieIsLost merged commit c8ab223 into paradigmxyz:main Jul 6, 2023
@jmcph4 jmcph4 mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankieIsLost FrankieIsLost FrankieIsLost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcph4 @FrankieIsLost