Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seaport v5 contract as part of Seaport 1.5 release #14

Merged
merged 1 commit into from
May 16, 2023

Conversation

JohnChangUK
Copy link
Contributor

@JohnChangUK JohnChangUK commented May 14, 2023

Description

Add Seaport v1.5 Contract address as part of the Seaport 1.5 release. Without this fix, there is an error when sending the request with the Opensea API. The error is more specifically:

INFO opensea_sudo_arb::strategy: Error getting order from opensea: error decoding response body: missing field protocol at line 1 column 57

References

Seaport 1.5 release: https://docs.opensea.io/changelog/seaport-1-5-release
Seaport 1.5 contract address: 0x00000000000000ADc04C56Bf30aC9d3c0aAF14dC

@FrankieIsLost
Copy link
Collaborator

Thank you! Could we please add a new test parsing actual response data for seaport1.5 from the API instead of replacing the current test? Want to make sure we maintain backwards compatibility. This test data should be simple to get from CURLing the endpoint (we should avoid using the payload in the documentation because the docs often do not match the actual response you get from the endpoint)

@JohnChangUK
Copy link
Contributor Author

JohnChangUK commented May 14, 2023

Thank you! Could we please add a new test parsing actual response data for seaport1.5 from the API instead of replacing the current test? Want to make sure we maintain backwards compatibility. This test data should be simple to get from CURLing the endpoint (we should avoid using the payload in the documentation because the docs often do not match the actual response you get from the endpoint)

Good shout, added the test in! Got the JSON payload from sending a request to the v1.5 protocol_address 0x00000000000000ADc04C56Bf30aC9d3c0aAF14dC

Copy link
Collaborator

@FrankieIsLost FrankieIsLost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankieIsLost FrankieIsLost merged commit 8b2948f into paradigmxyz:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants