Chores in opensea_sudo_arb strategy (#21)

* Add gas snapshot * Minor strategy README fixes * Update seaport to a constant * Natspec typo fix * Cover unprofitable arb scenario * Use custom error instead of revert string * Binding updates
paradigmxyz · Jun 7, 2023 · 88b664b · 88b664b
1 parent 5311f4b
commit 88b664b
Show file tree

Hide file tree

Showing 43 changed files with 2,758 additions and 2,576 deletions.
diff --git a/crates/strategies/opensea-sudo-arb/.gas-snapshot b/crates/strategies/opensea-sudo-arb/.gas-snapshot
@@ -0,0 +1,4 @@
+SudoOpenseaArbTest:testArb() (gas: 479364)
+SudoOpenseaArbTest:testUnprofitableArb() (gas: 479798)
+SudoPairQuoterTest:testCorrectSingleQuote() (gas: 38910)
+SudoPairQuoterTest:testCorrectnessMultiQuote() (gas: 50341)
diff --git a/crates/strategies/opensea-sudo-arb/README.md b/crates/strategies/opensea-sudo-arb/README.md
@@ -32,7 +32,7 @@ This strategy relies on two contracts:
 In order to run the solidity test, you need access to an alchemy/infura key. You can run tests with the following command: 
 
 ```sh
-ETH_MAINNET_HTTP=<YOUR_KEY> forge test --root ./contracts
+ETH_MAINNET_HTTP=<YOUR_RPC_URL> forge test --root ./contracts
 ```
 
 You can run the rust tests with the following command: 
@@ -44,5 +44,5 @@ cargo test
 And if you need to regenerate rust bindings for contracts, you can run 
 
 ```sh
-forge bind --bindings-path ./bindings --root ./contracts --crate-name bindings
+forge bind --bindings-path ./bindings --root ./contracts --crate-name bindings --overwrite
 ```
diff --git a/crates/strategies/opensea-sudo-arb/bindings/src/address.rs b/crates/strategies/opensea-sudo-arb/bindings/src/address.rs
@@ -115,38 +115,38 @@ pub mod address {
         34,
         18,
         32,
-        202,
-        152,
-        70,
         239,
-        211,
-        52,
-        127,
-        9,
+        33,
+        119,
+        255,
+        244,
+        226,
+        10,
+        14,
+        123,
+        138,
+        128,
         5,
-        7,
-        198,
-        216,
-        163,
-        130,
-        181,
-        77,
-        26,
-        189,
-        127,
-        76,
+        226,
+        135,
+        19,
+        221,
+        115,
+        120,
+        213,
+        229,
         82,
-        240,
-        142,
-        21,
-        220,
-        79,
-        90,
-        195,
-        140,
+        238,
+        30,
+        26,
+        244,
+        152,
+        187,
+        53,
         136,
-        86,
-        36,
+        124,
+        55,
+        205,
         100,
         115,
         111,
@@ -155,7 +155,7 @@ pub mod address {
         67,
         0,
         8,
-        17,
+        19,
         0,
         51,
     ];
@@ -208,38 +208,38 @@ pub mod address {
         34,
         18,
         32,
-        202,
-        152,
-        70,
         239,
-        211,
-        52,
-        127,
-        9,
+        33,
+        119,
+        255,
+        244,
+        226,
+        10,
+        14,
+        123,
+        138,
+        128,
         5,
-        7,
-        198,
-        216,
-        163,
-        130,
-        181,
-        77,
-        26,
-        189,
-        127,
-        76,
+        226,
+        135,
+        19,
+        221,
+        115,
+        120,
+        213,
+        229,
         82,
-        240,
-        142,
-        21,
-        220,
-        79,
-        90,
-        195,
-        140,
+        238,
+        30,
+        26,
+        244,
+        152,
+        187,
+        53,
         136,
-        86,
-        36,
+        124,
+        55,
+        205,
         100,
         115,
         111,
@@ -248,7 +248,7 @@ pub mod address {
         67,
         0,
         8,
-        17,
+        19,
         0,
         51,
     ];

diff --git a/crates/strategies/opensea-sudo-arb/bindings/src/amount_deriver.rs b/crates/strategies/opensea-sudo-arb/bindings/src/amount_deriver.rs
@@ -66,38 +66,38 @@ pub mod amount_deriver {
         34,
         18,
         32,
-        54,
-        211,
-        8,
+        145,
         38,
-        142,
-        160,
-        101,
-        90,
-        161,
+        15,
+        211,
+        59,
+        19,
+        224,
+        95,
+        197,
+        195,
+        173,
+        147,
+        158,
+        247,
+        70,
+        131,
+        169,
+        154,
         72,
-        36,
-        133,
+        107,
         64,
-        158,
-        38,
-        66,
-        182,
-        11,
-        52,
-        180,
-        222,
-        243,
-        217,
-        199,
-        53,
-        180,
-        208,
-        45,
-        171,
-        25,
-        14,
-        132,
+        251,
+        197,
+        247,
+        227,
+        169,
+        0,
+        124,
+        64,
+        252,
+        71,
+        160,
         100,
         115,
         111,
@@ -106,7 +106,7 @@ pub mod amount_deriver {
         67,
         0,
         8,
-        17,
+        19,
         0,
         51,
     ];
@@ -136,38 +136,38 @@ pub mod amount_deriver {
         34,
         18,
         32,
-        54,
-        211,
-        8,
+        145,
         38,
-        142,
-        160,
-        101,
-        90,
-        161,
+        15,
+        211,
+        59,
+        19,
+        224,
+        95,
+        197,
+        195,
+        173,
+        147,
+        158,
+        247,
+        70,
+        131,
+        169,
+        154,
         72,
-        36,
-        133,
+        107,
         64,
-        158,
-        38,
-        66,
-        182,
-        11,
-        52,
-        180,
-        222,
-        243,
-        217,
-        199,
-        53,
-        180,
-        208,
-        45,
-        171,
-        25,
-        14,
-        132,
+        251,
+        197,
+        247,
+        227,
+        169,
+        0,
+        124,
+        64,
+        252,
+        71,
+        160,
         100,
         115,
         111,
@@ -176,7 +176,7 @@ pub mod amount_deriver {
         67,
         0,
         8,
-        17,
+        19,
         0,
         51,
     ];