Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr:
1.1 Missing single quotes around the string \xABCD -> '\xABCD' (...)
1.2 if bytes len is 0, it should be '' . '\x' -> ''.
duckdb hex: '\xAB\xCD'
postgres hex: '\xABCD'
It's not compatible. So ...I think it should implement postgres style in Wrapper repo. Duckdb style should be a user-defined function. And I implement
trait CellFormatter
allow to do that.This implementation is better than implementing the DuckDB pattern and more conducive to upstream.
raise a PR : feat: Add user-defined cell fmt interface supabase/wrappers#316