Draft NORDIC example #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
commented
Jan 2, 2025
| # Combine magnitude and phase into complex-valued data | ||
| complex_data = magnitude_data * np.exp(1j * phase_data) | ||
|
|
||
| # TODO: Filter complex data and calculate g-factor map |
There was a problem hiding this comment.
@paquiteau would adding these steps be useful for an example, or should they go into a function/class within patch-denoising?
There was a problem hiding this comment.
Well, this is already done in the load_complex_nifti function, which is what people would use in practice. I don't think it's needed to refactor that.
There was a problem hiding this comment.
Are you referring to combining the complex-valued data or the phase filtering and g-factor map creation? load_complex_nifti doesn't do the latter. Also, it doesn't rescale the phase data to -pi to pi, right? So this example definitely needs to separately rescale the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft of an example that applies NORDIC to complex-valued data with noise volumes.