Suggest using numeric whodunnit
column type for performance
#1456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using paper_trail and have billions of items in the
versions
table and the table is huge.One of the easy improvements that could have been done back then was using numeric type for
whodunnit
column. We currently plan to switch tointeger
which is 4 bytes, while using strings to store integer values can easily require much more space, like for1000000
it will require 8 bytes (padding included), so twice the space. And also integers have statis types, which is easier for databases to work with.So, I think it is a good idea at least to suggest people to consider switching to numeric types in the migration's comment.
master
(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.