Check for presence of Rails.env not just ::Rails #1003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One item in the test matrix failed (https://travis-ci.org/airblade/paper_trail/builds/289990814). I can't retry the build on Travis but this combination is passing on my machine so I'm guessing it's a random error. |
|
CI job #1516.11 restarted |
|
rails/activeresource#216 checks for |
like ActiveResource does
|
Ah, I saw |
|
Looks good. Thanks, Wojtek. Please add:
|
|
Closing via #1006 which preserves your authorship, and adds a warning instead of silently failing to load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Rails module is defined without Rails being loaded (e.g. rails-html-sanitizer defines this module). Instead let's check for Rails.env.
Solution taken from rails/activeresource#216