Draw line fix so that color actually works, plus extra functions for … #2195
Conversation
…drawing crosshairs and rectangles.
| // Go through all the points | ||
| for (uint16_t i = 0; i < points_cnt; i++) { | ||
| // Draw a line from the original position with the flow vector | ||
| struct point_t from = { | ||
| vectors[i].pos.x / subpixel_factor, | ||
| vectors[i].pos.y / subpixel_factor, | ||
| 0, |
There was a problem hiding this comment.
what about the other parameters of the point_t structure ? shouldn't they be initialized properly ?
if only x,y are needed in most case, maybe an init macro can be added to images.h to hide the other parameters initialization.
There was a problem hiding this comment.
Good remark! point_t got additional properties in a previous pull request - I believe by Manos. I wonder if this is actually the best way to go, as a point as a mathematical concept would not require properties such as the number of times observed. Perhaps a solution would be an additional struct with a point_t as one of its attributes. However, I feel this is beyond the scope of the current pull request.
There was a problem hiding this comment.
Can you make an issue about this so that it is addressed in the future?
There was a problem hiding this comment.
I don't think it's worth an issue
| @@ -578,27 +608,24 @@ void image_show_points(struct image_t *img, struct point_t *points, uint16_t poi | |||
| */ | |||
| void image_show_flow(struct image_t *img, struct flow_t *vectors, uint16_t points_cnt, uint8_t subpixel_factor) | |||
| { | |||
| uint8_t color[4] = {255,255,255,255}; | |||
| int size_crosshair = 5; | |||
There was a problem hiding this comment.
In the future, things like this can be declared static so that they are not constantly redeclared. alternatively you can consider using the const descriptor, helps with code clarity.
There was a problem hiding this comment.
I made it static now
There was a problem hiding this comment.
This was not specific to this line but in general, often you define a variable with a constant value, in that case a static or const (or both) descriptor is interesting. Consider it in the future.
| // Go through all the points | ||
| for (uint16_t i = 0; i < points_cnt; i++) { | ||
| // Draw a line from the original position with the flow vector | ||
| struct point_t from = { | ||
| vectors[i].pos.x / subpixel_factor, | ||
| vectors[i].pos.y / subpixel_factor, | ||
| 0, |
There was a problem hiding this comment.
Can you make an issue about this so that it is addressed in the future?
| else { | ||
| temp_color[0] = color[0]; | ||
| temp_color[2] = color[2]; | ||
| } |
There was a problem hiding this comment.
Don't forget to run fix code style. You can also change the settings of your editor so you don't have this problem in the future.
… rectangles (paparazzi#2195) * Draw line fix so that color actually works, plus extra functions for drawing crosshairs and rectangles. * Added static and formatted code style
…drawing crosshairs and rectangles.