Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precomputed Radiance Transfer Example #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stratosger
Copy link
Collaborator

This pull request adds the Precomputed Radiance Transfer baseline example to pyGandalf!

It can be found in the OpenGL examples, in the advanced category.

By default the diffuse interreflections case will be executed for 2 bounces. The computation of coefficients takes some time, so you will need to wait a bit before viewing the final result. (The program prints the procedure percentage to let the user know how long it will take.).

Any comments/feedback welcome!

@stratosger stratosger added the enhancement New feature or request label Jul 12, 2024
@stratosger stratosger self-assigned this Jul 12, 2024
Copy link
Collaborator

@aprotopsaltis aprotopsaltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I had to pip install imageio and opencv-python

It would be nice to see

  • the fps during a camera turn or a simple animation
  • the memory used
  • a checkbox to enable/disable of shadows/interreflectance

@stratosger
Copy link
Collaborator Author

Thank you for your comments!

I've noted all of them. However, regarding the FPS I think they are already located on the title-bar of the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants