Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of options on the list objects action #85

Merged

Conversation

irevoire
Copy link
Contributor

Hey, I don't know how you see your lib.
Would you be interested in this kind of addition that eases the use of parameters on the actions?

While using your lib, I made a few dumb typos and sometimes used the headers instead of the query parameters. And that took me a while to debug each time.

I thought it could be nice to have this kind of option embedded in the lib directly, but since there is a lot of non-standard parameter + many parameters in general, I don't know if it's the kind of stuff you're interested in. Let me know.

@paolobarbolini
Copy link
Owner

I like this idea. I think we can add parameters as long as they are "standard", meaning they are supported by the official AWS S3 service. We could also be ok with non-standard parameters, if there are any, as long as that's made clear by the documentation.

Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice

@paolobarbolini paolobarbolini merged commit 2dc4db5 into paolobarbolini:main Oct 4, 2023
6 of 7 checks passed
@irevoire irevoire deleted the add-options-on-list-objects branch October 9, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants