Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with_delimiter for list method #104

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Add with_delimiter for list method #104

merged 2 commits into from
Jul 20, 2024

Conversation

giangndm
Copy link
Contributor

This PR added missing with_delimiter option for list method

paolobarbolini
paolobarbolini approved these changes Jul 10, 2024
View reviewed changes
Copy link
Owner

@paolobarbolini paolobarbolini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. The CI has caught a typo in the docs, which I've fixed in the attached suggestion.

EDIT: breakage with the other CI jobs will be fixed separately

src/actions/list_objects_v2.rs Outdated Show resolved Hide resolved
@giangndm @paolobarbolini
Update src/actions/list_objects_v2.rs
cc9ecec 
Co-authored-by: Paolo Barbolini <paolo@paolo565.org>
@paolobarbolini paolobarbolini merged commit a7e6ebe into paolobarbolini:main Jul 20, 2024
6 of 7 checks passed
@paolobarbolini
Copy link
Owner

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guerinoni guerinoni guerinoni approved these changes

@paolobarbolini paolobarbolini paolobarbolini approved these changes

Assignees

@paolobarbolini paolobarbolini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giangndm @paolobarbolini @guerinoni