Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more attributes to Overview class #71

Merged
merged 1 commit into from
Mar 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions mlbgame/game.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,14 @@ def overview(game_id):
# parse data
overview_root = etree.parse(overview).getroot()
raw_box_score_root = etree.parse(raw_box_score).getroot()

output = {}
# get overview attributes
for x in overview_root.attrib:
output[x] = overview_root.attrib[x]
# get attendance from raw box score
output['attendance'] = raw_box_score_root.attrib['attendance']
# get raw box score attributes
for x in raw_box_score_root.attrib:
output[x] = raw_box_score_root.attrib[x]

# Get probable starter attributes if they exist
home_pitcher_tree = overview_root.find('home_probable_pitcher')
Expand Down Expand Up @@ -424,10 +426,13 @@ class Overview(mlbgame.object.Object):
away_time_zone
away_win
balls
date
day
double_header_sw
elapsed_time
first_pitch_et
game_data_directory
game_id
game_nbr
game_pk
game_type
Expand Down Expand Up @@ -480,12 +485,15 @@ class Overview(mlbgame.object.Object):
league
location
note
official_scorer
original_date
outs
photos_link
preview
scheduled_innings
start_time
status
status_ind
strikes
tbd_flag
tiebreaker_sw
Expand All @@ -504,7 +512,10 @@ class Overview(mlbgame.object.Object):
tz_hm_lg_gen
venue
venue_id
venue_name
venue_w_chan_loc
weather
wind
wrapup_link
"""
pass
Expand Down
9 changes: 9 additions & 0 deletions tests/test_game.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,13 @@ def test_overview(self):
self.assertEqual(overview.away_time_zone, 'ET')
self.assertEqual(overview.away_win, 53)
self.assertEqual(overview.balls, 0)
self.assertEqual(overview.date, 'August 2, 2016')
self.assertEqual(overview.day, 'TUE')
self.assertEqual(overview.double_header_sw, 'N')
self.assertEqual(overview.elapsed_time, '2:39')
self.assertEqual(overview.first_pitch_et, '')
self.assertEqual(overview.game_data_directory, '/components/game/mlb/year_2016/month_08/day_02/gid_2016_08_02_nyamlb_nynmlb_1')
self.assertEqual(overview.game_id, '2016/08/02/nyamlb-nynmlb-1')
self.assertEqual(overview.game_nbr, 1)
self.assertEqual(overview.game_pk, 448453)
self.assertEqual(overview.game_type, 'R')
Expand Down Expand Up @@ -251,12 +254,15 @@ def test_overview(self):
self.assertEqual(overview.league, 'AN')
self.assertEqual(overview.location, 'Flushing, NY')
self.assertEqual(overview.note, '')
self.assertEqual(overview.official_scorer, 'Jordan Sprechman')
self.assertEqual(overview.original_date, '2016/08/02')
self.assertEqual(overview.outs, 3)
self.assertEqual(overview.photos_link, '/mlb/gameday/index.jsp?gid=2016_08_02_nyamlb_nynmlb_1&mode=photos')
self.assertEqual(overview.preview, '/mlb/gameday/index.jsp?gid=2016_08_02_nyamlb_nynmlb_1&mode=preview&c_id=mlb')
self.assertEqual(overview.scheduled_innings, 9)
self.assertEqual(overview.start_time, '7:11 PM')
self.assertEqual(overview.status, 'Final')
self.assertEqual(overview.status_ind, 'F')
self.assertEqual(overview.strikes, 0)
self.assertEqual(overview.tbd_flag, 'N')
self.assertEqual(overview.tiebreaker_sw, 'N')
Expand All @@ -275,7 +281,10 @@ def test_overview(self):
self.assertEqual(overview.tz_hm_lg_gen, 'ET')
self.assertEqual(overview.venue, 'Citi Field')
self.assertEqual(overview.venue_id, 3289)
self.assertEqual(overview.venue_name, 'Citi Field')
self.assertEqual(overview.venue_w_chan_loc, 'USNY0504')
self.assertEqual(overview.weather, '75 degrees, partly cloudy')
self.assertEqual(overview.wind, '8 mph, R to L')
self.assertEqual(overview.wrapup_link, '/mlb/gameday/index.jsp?gid=2016_08_02_nyamlb_nynmlb_1&mode=wrap&c_id=mlb')

def test_overview_empty(self):
Expand Down