Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probable starter attributes, fixes #32 #64

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Add probable starter attributes, fixes #32 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 77 additions & 1 deletion mlbgame/game.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def __iter__(self):
"""Allows object to be iterated over."""
for x in self.innings:
yield x

def __enumerate_scoreboard(self, data):
output = ''
for y, x in enumerate(data, start=1):
Expand Down Expand Up @@ -329,6 +329,50 @@ def overview(game_id):
# get overview attributes
for x in root.attrib:
output[x] = root.attrib[x]

# Get probable starter attributes if they exist
home_pitcher_tree = root.find('home_probable_pitcher')
if home_pitcher_tree is not None:
output.update(build_namespaced_attributes(
'home_probable_pitcher', home_pitcher_tree))
else:
output.update(build_probable_starter_defaults('home'))

away_pitcher_tree = root.find('away_probable_pitcher')
if away_pitcher_tree is not None:
output.update(build_namespaced_attributes(
'away_probable_pitcher', away_pitcher_tree))
else:
output.update(build_probable_starter_defaults('away'))

return output


def build_namespaced_attributes(name, tree):
output = {}
for attr in tree.attrib:
output[name + '_' + attr] = tree.attrib[attr]
return output


def build_probable_starter_defaults(name):
output = {}
output[name + '_probable_pitcher_era'] = ''
output[name + '_probable_pitcher_first'] = ''
output[name + '_probable_pitcher_first_name'] = ''
output[name + '_probable_pitcher_id'] = ''
output[name + '_probable_pitcher_last'] = ''
output[name + '_probable_pitcher_last_name'] = ''
output[name + '_probable_pitcher_losses'] = ''
output[name + '_probable_pitcher_name_display_roster'] = ''
output[name + '_probable_pitcher_number'] = ''
output[name + '_probable_pitcher_s_era'] = ''
output[name + '_probable_pitcher_s_losses'] = ''
output[name + '_probable_pitcher_s_wins'] = ''
output[name + '_probable_pitcher_stats_season'] = ''
output[name + '_probable_pitcher_stats_type'] = ''
output[name + '_probable_pitcher_throwinghand'] = ''
output[name + '_probable_pitcher_wins'] = ''
return output


Expand All @@ -348,6 +392,22 @@ class Overview(mlbgame.object.Object):
away_loss
away_name_abbrev
away_preview_link
away_probable_pitcher_era
away_probable_pitcher_first
away_probable_pitcher_first_name
away_probable_pitcher_id
away_probable_pitcher_last
away_probable_pitcher_last_name
away_probable_pitcher_losses
away_probable_pitcher_name_display_roster
away_probable_pitcher_number
away_probable_pitcher_s_era
away_probable_pitcher_s_losses
away_probable_pitcher_s_wins
away_probable_pitcher_stats_season
away_probable_pitcher_stats_type
away_probable_pitcher_throwinghand
away_probable_pitcher_wins
away_recap_link
away_sport_code
away_team_city
Expand Down Expand Up @@ -380,6 +440,22 @@ class Overview(mlbgame.object.Object):
home_loss
home_name_abbrev
home_preview_link
home_probable_pitcher_era
home_probable_pitcher_first
home_probable_pitcher_first_name
home_probable_pitcher_id
home_probable_pitcher_last
home_probable_pitcher_last_name
home_probable_pitcher_losses
home_probable_pitcher_name_display_roster
home_probable_pitcher_number
home_probable_pitcher_s_era
home_probable_pitcher_s_losses
home_probable_pitcher_s_wins
home_probable_pitcher_stats_season
home_probable_pitcher_stats_type
home_probable_pitcher_throwinghand
home_probable_pitcher_wins
home_recap_link
home_sport_code
home_team_city
Expand Down
32 changes: 32 additions & 0 deletions tests/test_game.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,22 @@ def test_overview(self):
self.assertEqual(overview.away_loss, 53)
self.assertEqual(overview.away_name_abbrev, 'NYY')
self.assertEqual(overview.away_preview_link, '/mlb/gameday/index.jsp?gid=2016_08_02_nyamlb_nynmlb_1&mode=preview&c_id=mlb')
self.assertIsInstance(overview.away_probable_pitcher_era, str)
self.assertIsInstance(overview.away_probable_pitcher_first, str)
self.assertIsInstance(overview.away_probable_pitcher_first_name, str)
self.assertIsInstance(overview.away_probable_pitcher_id, str)
self.assertIsInstance(overview.away_probable_pitcher_last, str)
self.assertIsInstance(overview.away_probable_pitcher_last_name, str)
self.assertIsInstance(overview.away_probable_pitcher_losses, str)
self.assertIsInstance(overview.away_probable_pitcher_name_display_roster, str)
self.assertIsInstance(overview.away_probable_pitcher_number, str)
self.assertIsInstance(overview.away_probable_pitcher_s_era, str)
self.assertIsInstance(overview.away_probable_pitcher_s_losses, str)
self.assertIsInstance(overview.away_probable_pitcher_s_wins, str)
self.assertIsInstance(overview.away_probable_pitcher_stats_season, str)
self.assertIsInstance(overview.away_probable_pitcher_stats_type, str)
self.assertIsInstance(overview.away_probable_pitcher_throwinghand, str)
self.assertIsInstance(overview.away_probable_pitcher_wins, str)
self.assertEqual(overview.away_recap_link, '/mlb/gameday/index.jsp?gid=2016_08_02_nyamlb_nynmlb_1&mode=recap&c_id=mlb')
self.assertEqual(overview.away_sport_code, 'mlb')
self.assertEqual(overview.away_team_city, 'NY Yankees')
Expand Down Expand Up @@ -198,6 +214,22 @@ def test_overview(self):
self.assertEqual(overview.home_loss, 51)
self.assertEqual(overview.home_name_abbrev, 'NYM')
self.assertEqual(overview.home_preview_link, '/mlb/gameday/index.jsp?gid=2016_08_02_nyamlb_nynmlb_1&mode=preview&c_id=mlb')
self.assertIsInstance(overview.home_probable_pitcher_era, str)
self.assertIsInstance(overview.home_probable_pitcher_first, str)
self.assertIsInstance(overview.home_probable_pitcher_first_name, str)
self.assertIsInstance(overview.home_probable_pitcher_id, str)
self.assertIsInstance(overview.home_probable_pitcher_last, str)
self.assertIsInstance(overview.home_probable_pitcher_last_name, str)
self.assertIsInstance(overview.home_probable_pitcher_losses, str)
self.assertIsInstance(overview.home_probable_pitcher_name_display_roster, str)
self.assertIsInstance(overview.home_probable_pitcher_number, str)
self.assertIsInstance(overview.home_probable_pitcher_s_era, str)
self.assertIsInstance(overview.home_probable_pitcher_s_losses, str)
self.assertIsInstance(overview.home_probable_pitcher_s_wins, str)
self.assertIsInstance(overview.home_probable_pitcher_stats_season, str)
self.assertIsInstance(overview.home_probable_pitcher_stats_type, str)
self.assertIsInstance(overview.home_probable_pitcher_throwinghand, str)
self.assertIsInstance(overview.home_probable_pitcher_wins, str)
self.assertEqual(overview.home_recap_link, '/mlb/gameday/index.jsp?gid=2016_08_02_nyamlb_nynmlb_1&mode=recap&c_id=mlb')
self.assertEqual(overview.home_sport_code, 'mlb')
self.assertEqual(overview.home_team_city, 'NY Mets')
Expand Down