fix: await the result returned by resourceIndicators.useGrantedResource function, in resolve_resource.js

[Starrah]

First, thank all the contributors for your effort in building this awesome project, which helps me a lot! During my usage, I found something that maybe a minor bug.

The features.resourceIndicators.useGrantedResource function defined in the config can be async function. In fact, the default value for that is indeed an async function:

node-oidc-provider/lib/helpers/defaults.js

Lines 201 to 206 in 2ba8395

	async function useGrantedResource(ctx, model) {
	// @param ctx - koa request context
	// @param model - depending on the request's grant_type this can be either an AuthorizationCode, BackchannelAuthenticationRequest,
	// RefreshToken, or DeviceCode model instance.
	return false;
	}

However, when the function is called in resolver_resource.js, which is used to resolve the resource for a auth or token request, the value returned by useGrantedResource is not awaited:

node-oidc-provider/lib/helpers/resolve_resource.js

Line 14 in 2ba8395

case model.resource && !!config.resourceIndicators.useGrantedResource(ctx, model):

In my opinion, this is a bug, which makes the useGrantedResource configration have no effect, since !! a Promise will always equals to true.

Thank you for your review!

[panva]

Nice catch!

Can you please update https://github.com/panva/node-oidc-provider/blob/main/test/resource_indicators/resource_indicators.config.js#L41-L43 to be an async function? That way this fix will actually be tested.

[Starrah]

Nice catch!

Can you please update https://github.com/panva/node-oidc-provider/blob/main/test/resource_indicators/resource_indicators.config.js#L41-L43 to be an async function? That way this fix will actually be tested.

Updated the test with 246ca00 (force-pushed).

[panva]

@Starrah thank you for your contribution! I'd be interested in learning about your use of oidc-provider and the resourceIndicators feature and welcome any further contribution you might have to e.g. to documentation that was difficult to process.