Skip to content

Commit

Permalink
fix: ignore post_logout_redirect_uris when logout is disabled (#1221)
Browse files Browse the repository at this point in the history
  • Loading branch information
manvydasu authored May 6, 2023
1 parent 095ca06 commit d7dd6cf
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ location / {
- [requestObjects](#featuresrequestobjects)
- [resourceIndicators ❗](#featuresresourceindicators)
- [revocation](#featuresrevocation)
- [rpInitiatedLogout](#featuresrpinitiatedlogout)
- [userinfo](#featuresuserinfo)
- [acrValues](#acrvalues)
- [allowOmittingSingleRegisteredRedirectUri](#allowomittingsingleregisteredredirecturi)
Expand Down
1 change: 0 additions & 1 deletion lib/consts/client_attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const RECOGNIZED_METADATA = [
'jwks',
'logo_uri',
'policy_uri',
'post_logout_redirect_uris',
'redirect_uris',
'require_auth_time',
'response_types',
Expand Down
6 changes: 4 additions & 2 deletions test/configuration/client_metadata.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,10 @@ describe('Client metadata validation', () => {
});

context('post_logout_redirect_uris', function () {
defaultsTo(this.title, [], undefined);
defaultsTo(this.title, [], { post_logout_redirect_uris: undefined });
defaultsTo(this.title, []);
defaultsTo(this.title, undefined, undefined, {
features: { rpInitiatedLogout: { enabled: false } },
});
mustBeArray(this.title, [{}, 'string', 123, true]);
rejects(this.title, [123], /must only contain strings$/);

Expand Down

0 comments on commit d7dd6cf

Please sign in to comment.