Port engine/legacy integration tests to V2
#8363
Conversation
| @@ -1,26 +1,6 @@ | |||
| # Copyright 2014 Pants project contributors (see CONTRIBUTORS.md). | |||
| # Licensed under the Apache License, Version 2.0 (see LICENSE). | |||
|
|
|||
| scala_library( | |||
| name = 'jvm-run-example-lib', | |||
There was a problem hiding this comment.
This is moved to a subdirectory. Keeping it at the root has major problems that we then need to have the IT pull in dependencies for other targets in this BUILD which have nothing to do with the IT.
tests/python/pants_test/engine/legacy/test_build_ignore_integration.py
Outdated
Show resolved
Hide resolved
| '--no-v1', | ||
| '--v2', | ||
| 'list', | ||
| '::', |
There was a problem hiding this comment.
We no longer glob against everything. This is not feasible because we cannot sanely depend on every single file in the repo.
| 'src/::',] | ||
|
|
||
| result = runner(command) | ||
| result = runner(['list', self.list_target]) | ||
| checker.assert_started() | ||
| return result |
There was a problem hiding this comment.
I'm not clear how this test really is checking that we don't cache. A sanity check on this change (i.e. not running against all of src/:: would be helpful).
There was a problem hiding this comment.
I know this is merged, but just in case.
There was a problematic interaction between pantsd and the v2 graph a while ago.
The @console_rules would cache their result in the v2 graph, so two consecutive runs of a console_rule under pantsd would only run once, and the output wouldn't show on the second run.
There was a problem hiding this comment.
Got it. So this test should still work for checking that, right?
Also note that this does not have @ensure_daemon. Is that intentional?
There was a problem hiding this comment.
Got it. So this test should still work for checking that, right?
Yeap, it's a regression test, to make sure it never happens again.
Also note that this does not have @ensure_daemon. Is that intentional?
Yeah, the context manager is set to pantsd_successful_run, which will only trigger under pantsd. The nature of the bug that this regression test is testing means that pantsd is the only place it will manifest.
| @@ -22,7 +22,7 @@ def setUp(self): | |||
| scan_set = set() | |||
|
|
|||
| def should_ignore(file): | |||
| return file.endswith('.pyc') | |||
| return file.endswith('.pyc') or file.endswith('__init__.py') | |||
There was a problem hiding this comment.
V2 injects __init__.py that isn't normally there.
tests/python/pants_test/engine/legacy/test_build_ignore_integration.py
Outdated
Show resolved
Hide resolved
This reverts commit 763f7a8.
Similar to #8361, it was not obvious how to port all these tests because several of these ITs glob against all of
testprojects, which is not possible with a chroot.When combined with #8361, brings the number of remoted ITs (#8113) to 80%.