-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark one test from mostly-non-JS/JVM backends as platform-specific behaviour, test on macOS #21610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
added
the
release-notes:not-required
PR doesn't require mention in release notes
label
Nov 4, 2024
This was referenced Nov 6, 2024
benjyw
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of me thinks we should run all tests on all platforms and be done with it...
Yeah, agreed: #20193 😄 |
cognifloyd
approved these changes
Nov 7, 2024
huonw
added a commit
that referenced
this pull request
Nov 8, 2024
…ecific behaviour, test on macOS (#21620) Continuing #21610, this adds the `platform_specific_behavior` flag to two additional backends (hadolint and golangci_lint), that require installing Go on the CI machines. (I think Hadolint requires Go to build the `dockerfile` Python package on Linux arm64.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes through many backends and marks one test as
platform_specific_behavior
to ensure the backends have some testing on platforms other than x86-64 Linux (macOS, and arm64 Linux).The particular value in doing this is validating the set-up code, e.g. got the right configuration for installing/downloading the tool, rather than validating the details of the behaviour. I think we generally assume most tools behave similar across platforms, once they're up and running.
This PR focuses on non-JVM and non-JS backends, meaning raw binaries (
ExternalTool
mTemplatedExternalTool
) and Python tools installed from PyPI (PythonToolBase
,PythonToolRequirementsBase
). It particularly focuses on the backends that don't require installing any additional software in CI, see #21620 and #21621 for additional backends that do require installing Go and Docker respectively.The impression I get is the JVM and JS tools are more platform-independent, often? For instance, their lockfiles/artifacts don't mention specific platforms, unlike Python wheels.
I found these backends via the following shell command, plus other exploration:
I may've missed some!
This increases the time to run tests in CI on the relevant platforms, by slight more than 2×.
Related: #21608, #20193, #20993