Use a list of requirement constraints for lockfile invalidation - #16469
Merged
Eric-Arellano merged 3 commits intoAug 10, 2022
Merged
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added
the
category:internal
Eric-Arellano
marked this pull request as ready for review
August 10, 2022 19:15
jsirois
approved these changes
Aug 10, 2022
|
|
||
| @dataclass | ||
| class _PipArgsAndConstraintsSetup: | ||
| args: list[str] |
Contributor
There was a problem hiding this comment.
This works since _PipArgsAndConstraintsSetup is private and only a return type of a helper, but having to look at any un-frozen struct, at least for me, raises suspicion reading rule code. If there was some mysterious bug reported and I was scanning the codebase, this would cause me to burn un-needed time reviewing why this is OK. I may be a poor example here though of a code reader.
Contributor
Author
There was a problem hiding this comment.
True. I myself was a bit confused trying to trace whether this was safe or not. Thanks
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Contributor
|
Woohoo, thanks for the consideration! 😄 |
Contributor
Author
|
And thank you for the recommendation! It was a great one, and it shed light on 2 other uncertainties I had re: lockfile metadata for this project :D |
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…sbuild#16469) Improves upon pantsbuild#16420. @huonw wisely suggested we avoid using `hash` for constraints files because it makes Git diffs and merge conflicts much worse. python-poetry/poetry#496 rust-lang/cargo#7070 [ci skip-rust] [ci skip-build-wheels]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves upon #16420. @huonw wisely suggested we avoid using
hashfor constraints files because it makes Git diffs and merge conflicts much worse. python-poetry/poetry#496 rust-lang/cargo#7070[ci skip-rust]
[ci skip-build-wheels]