Skip to content

add JSON serialization example for Kotlin #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 25, 2022
Merged

add JSON serialization example for Kotlin #1

merged 5 commits into from
May 25, 2022

Conversation

tdyas
Copy link

@tdyas tdyas commented May 14, 2022

Add a contrived example of using the Kotlin Serialization plugin to encode and decode JSON data.

@tdyas
Copy link
Author

tdyas commented May 14, 2022

Note: I pushed pants.toml directly to main as the initial commit. Probably worth reviewing pants.toml as well despite it not being in this PR.

@tdyas tdyas mentioned this pull request May 14, 2022
Closed
Eric-Arellano
Eric-Arellano approved these changes May 14, 2022
View reviewed changes
Copy link

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tdyas
Copy link
Author

tdyas commented May 16, 2022 •
edited
Loading

CI failure:

  ClasspathRootOnlyWasInner: The following targets had dependees, but can only be used as roots in a build graph:
  * src/jvm/org/pantsbuild/example/json/JsonExample.kt	(kotlin_source)

https://github.com/pantsbuild/example-kotlin/runs/6438158675?check_suite_focus=true#step:6:11

@stuhood / @chrisjrn: Thoughts on this failure? kotlin_source is not marked as root only. Only deploy_jar is marked with root_only=True. (Technically the ClasspathEntryRequest being marked.)

@stuhood
Copy link
Member

stuhood commented May 16, 2022

CI failure:

  ClasspathRootOnlyWasInner: The following targets had dependees, but can only be used as roots in a build graph:
  * src/jvm/org/pantsbuild/example/json/JsonExample.kt	(kotlin_source)

https://github.com/pantsbuild/example-kotlin/runs/6438158675?check_suite_focus=true#step:6:11

@stuhood / @chrisjrn: Thoughts on this failure? kotlin_source is not marked as root only. Only deploy_jar is marked with root_only=True. (Technically the ClasspathEntryRequest being marked.)

Bug...

It looks like this code is looking at a loop variable: https://github.com/pantsbuild/pants/blob/43a3ab258f36e74a84ea2b2091c5a374259677d4/src/python/pants/jvm/compile.py#L121-L125

@tdyas
Copy link
Author

tdyas commented May 16, 2022

CI failure:

  ClasspathRootOnlyWasInner: The following targets had dependees, but can only be used as roots in a build graph:
  * src/jvm/org/pantsbuild/example/json/JsonExample.kt	(kotlin_source)

https://github.com/pantsbuild/example-kotlin/runs/6438158675?check_suite_focus=true#step:6:11
@stuhood / @chrisjrn: Thoughts on this failure? kotlin_source is not marked as root only. Only deploy_jar is marked with root_only=True. (Technically the ClasspathEntryRequest being marked.)

Bug...

It looks like this code is looking at a loop variable: https://github.com/pantsbuild/pants/blob/43a3ab258f36e74a84ea2b2091c5a374259677d4/src/python/pants/jvm/compile.py#L121-L125

Good eyes!

@tdyas tdyas mentioned this pull request May 16, 2022
Merged
@tdyas
Copy link
Author

tdyas commented May 16, 2022

pantsbuild/pants#15494 appears to fix the issue.

tdyas pushed a commit to pantsbuild/pants that referenced this pull request May 16, 2022
jvm: fix incorrect check for root-only ClasspathEntryRequest implem…
397bdb7 
…entations (#15494)

The conditional logic which checked for a root-only `ClasspathEntryRequest` implementation in a non-root position looked at a loop variable which could be unrelated to the compatible `ClasspathEntryRequest` implementation at issue. 

Solution: Check the root-only status of the compatible `ClasspathEntryRequest` implementation and avoid checking the loop variable.

h/t to @stuhood for spotting the bug. pantsbuild/example-kotlin#1 (comment)

[ci skip-rust]

[ci skip-build-wheels]
tdyas pushed a commit to tdyas/pants that referenced this pull request May 16, 2022
jvm: fix incorrect check for root-only ClasspathEntryRequest implem…
b9c18a7 
…entations (pantsbuild#15494)

The conditional logic which checked for a root-only `ClasspathEntryRequest` implementation in a non-root position looked at a loop variable which could be unrelated to the compatible `ClasspathEntryRequest` implementation at issue. 

Solution: Check the root-only status of the compatible `ClasspathEntryRequest` implementation and avoid checking the loop variable.

h/t to @stuhood for spotting the bug. pantsbuild/example-kotlin#1 (comment)

[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas mentioned this pull request May 16, 2022
Merged
tdyas pushed a commit to tdyas/pants that referenced this pull request May 16, 2022
jvm: fix incorrect check for root-only ClasspathEntryRequest implem…
6b6932c 
…entations (pantsbuild#15494)

The conditional logic which checked for a root-only `ClasspathEntryRequest` implementation in a non-root position looked at a loop variable which could be unrelated to the compatible `ClasspathEntryRequest` implementation at issue. 

Solution: Check the root-only status of the compatible `ClasspathEntryRequest` implementation and avoid checking the loop variable.

h/t to @stuhood for spotting the bug. pantsbuild/example-kotlin#1 (comment)

[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas mentioned this pull request May 16, 2022
Merged
tdyas pushed a commit to pantsbuild/pants that referenced this pull request May 17, 2022
jvm: fix incorrect check for root-only ClasspathEntryRequest implem…
cb6e87d 
…entations (Cherry pick of #15494) (#15497)

The conditional logic which checked for a root-only `ClasspathEntryRequest` implementation in a non-root position looked at a loop variable which could be unrelated to the compatible `ClasspathEntryRequest` implementation at issue. 

Solution: Check the root-only status of the compatible `ClasspathEntryRequest` implementation and avoid checking the loop variable.

h/t to @stuhood for spotting the bug. pantsbuild/example-kotlin#1 (comment)

[ci skip-rust]

[ci skip-build-wheels]
tdyas pushed a commit to pantsbuild/pants that referenced this pull request May 17, 2022
jvm: fix incorrect check for root-only ClasspathEntryRequest implem…
18659e5 
…entations (Cherry pick of #15494) (#15496)

The conditional logic which checked for a root-only `ClasspathEntryRequest` implementation in a non-root position looked at a loop variable which could be unrelated to the compatible `ClasspathEntryRequest` implementation at issue. 

Solution: Check the root-only status of the compatible `ClasspathEntryRequest` implementation and avoid checking the loop variable.

h/t to @stuhood for spotting the bug. pantsbuild/example-kotlin#1 (comment)

[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas merged commit 6f27e12 into pantsbuild:main May 25, 2022
@tdyas tdyas deleted the json_example branch May 25, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood Awaiting requested review from stuhood

@chrisjrn chrisjrn Awaiting requested review from chrisjrn

1 more reviewer

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdyas @stuhood @Eric-Arellano