Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HintComponent and ErrorMessageComponent #98

Merged
merged 17 commits into from
Jan 27, 2022
Merged

Add HintComponent and ErrorMessageComponent #98

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e9468a5
Add ErrorMessageComponent and HintComponent
tmaier Jan 3, 2022
06e8799
Add unit tests
tmaier Jan 3, 2022
542fe79
Add Builder#error_message and Builder#hint
tmaier Jan 3, 2022
07a4666
Update README
tmaier Jan 3, 2022
d7126dc
Fix HintComponent#call and tests
tmaier Jan 5, 2022
acae9c9
Fix code style
tmaier Jan 5, 2022
a83381e
Fix code style issue RSpec/NamedSubject
tmaier Jan 14, 2022
85132a9
Make the README example more practical
tmaier Jan 14, 2022
dc20e36
Use double splat arguments to be Ruby 3 compatible
tmaier Jan 14, 2022
433d4ad
Fix README
tmaier Jan 18, 2022
cb2efbb
Change subject to rendered_component
tmaier Jan 18, 2022
b865904
Update spec/view_component/form/error_message_component_spec.rb
tmaier Jan 18, 2022
d5c3163
Update spec/view_component/form/error_message_component_spec.rb
tmaier Jan 18, 2022
23a50f9
Update spec/view_component/form/error_message_component_spec.rb
tmaier Jan 18, 2022
72556b5
Update app/components/view_component/form/hint_component.rb
tmaier Jan 18, 2022
9ba822e
Update spec/view_component/form/error_message_component_spec.rb
Spone Jan 26, 2022
50e08a4
Fix specs
tmaier Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update spec/view_component/form/error_message_component_spec.rb 
Co-authored-by: Simon Fish <si@mon.fish>
  • Loading branch information
@tmaier @boardfish
tmaier and boardfish authored Jan 18, 2022
commit d5c3163c68bcb200a12102abc4f990eed75744b7
6 changes: 1 addition & 5 deletions spec/view_component/form/error_message_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,7 @@ def name
it { expect(component.method_errors).to eq(["Can't be blank", "Is too short (minimum is 2 characters)"]) }
it { expect(component.render?).to be true }

it do
expect(rendered_component).to eq_html <<~HTML
<div>Can't be blank<br>Is too short (minimum is 2 characters)</div>
HTML
end
it { is_expected.to eq_html '<div>Can't be blank<br>Is too short (minimum is 2 characters)</div>' }
Spone marked this conversation as resolved.
Show resolved Hide resolved
end

include_examples "component with custom html classes"
Expand Down