Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pantheon to Github Action name. #8

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

kopepasah
Copy link
Contributor

@kopepasah kopepasah commented Oct 3, 2022

Since Pantheon now has an official Action for setting up Terminus, it is recommended that I deprecate my Action and Pantheon take the name in the Marketplace (to avoid developer confusion).

This will update the name in the Marketplace, making it more discoverable by people searching for Pantheon Terminus.

Please note this change first requires removing my Action from the Marketplace, so it will need to be done in conjunction with approval.

  1. Approve change.
  2. Remove Setup Pantheon Terminus (kopepasah) from Actions Marketplace.
  3. Merge change.

This will update the name in the Marketplace, making it more descoverable by people searching for Pantheon Terminus.
@kopepasah kopepasah requested a review from a team as a code owner October 3, 2022 03:18
@kopepasah
Copy link
Contributor Author

Side note: Personally, I would update the icon to zap, which is a lightning bolt. ⚡

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 3, 2022

fwiw I think it's fine as is because "Pantheon" is in the description and publisher name:

image

But I'll let Pantheon make the final call since its their action now :)

@namespacebrian namespacebrian merged commit f7e6669 into pantheon-systems:main Oct 6, 2022
@kopepasah
Copy link
Contributor Author

kopepasah commented Oct 8, 2022

My Action for setting up terminus in has been delisted from the Marketplace. You should now be able to release a new version, with the updated name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants