Add type declaration file for TypeScript users#20
Closed
merlinz01 wants to merge 2 commits intopanphora:mainfrom
Closed
Add type declaration file for TypeScript users#20merlinz01 wants to merge 2 commits intopanphora:mainfrom
merlinz01 wants to merge 2 commits intopanphora:mainfrom
Conversation
Closed
Owner
|
Thank you for this contribution! I've just merged a comprehensive TypeScript definitions file that addresses the need for TypeScript support. The implementation I've added includes:
The definitions cover all the functionality including the main OverType class, all configuration options, theme system, toolbar, shortcuts, and static methods. Since TypeScript support has now been added to the main branch (commit 4c324d0), I'll close this PR. Thank you again for bringing this to our attention and for your initial implementation! |
panphora
added a commit
that referenced
this pull request
Aug 20, 2025
Credit kbhomes for overscroll fix (#17) and merlinz01 for TypeScript definitions (#20) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Update: Your contribution has been credited in the README! Thank you again for helping improve OverType with TypeScript support. You can see the credit here: https://github.com/panphora/overtype#contributors |
panphora
added a commit
that referenced
this pull request
Aug 20, 2025
Credit kbhomes for overscroll fix (#17) and merlinz01 for TypeScript definitions (#20) 🤖 Generated with [Claude Code](https://claude.ai/code)
panphora
added a commit
that referenced
this pull request
Aug 20, 2025
Credit kbhomes for overscroll fix (#17) and merlinz01 for TypeScript definitions (#20) 🤖 Generated with [Claude Code](https://claude.ai/code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without type definitions, users who wish to use this library in their TypeScript project get build errors and no type checking. This PR adds a simple type declaration file and registers it in
package.json.Manually making these changes to the installed package in
node_modulesconfirms that it works: