Don't focus trap tab by default#115
Closed
riasvdv wants to merge 1 commit into
Closed
Conversation
panphora
added a commit
that referenced
this pull request
Jun 18, 2026
…JSON, Safari fix Bundles several community fixes and features into one minor release. Added: - transformLinkUrl option for the link tooltip (#85) - Tab/Shift+Tab indent on selection, Cmd/Ctrl+] and Cmd/Ctrl+[ shortcuts, and public indentSelection()/outdentSelection() (#115) - JSON-aware data-ot-* parsing and data-ot-textarea-* shortcuts so textareaProps (e.g. required) works from HTML (#112) - Autocomplete recipe for @mention/#issue popups in docs/AUTOCOMPLETE.md (#96) Fixed: - Keyboard focus trap: collapsed Tab/Shift+Tab now uses native focus traversal so keyboard users can leave the editor, WCAG 2.1.2 (#113) - Toolbar accessibility following the W3C APG Toolbar pattern: roving tabindex, aria-pressed on toggle buttons only, aria-controls, menu-button semantics (#114) - Safari: re-flow the textarea after edits so caret/wrap stop desyncing from the overlay (#116) - exports.browser pointed to a non-existent file (overtype.iife.min.js); now overtype.min.js - Link tooltip sanitizes the URL before opening, closing a latent javascript: vector dist/ rebuilt from source. Full test suite passes, including the new keyboard-accessibility and toolbar a11y suites. Claude-Session: https://claude.ai/code/session_013uxKmCY2gqHzfV2jBQq27J
This was referenced Jun 18, 2026
Owner
|
Landed in v2.4.0 (22742e0), integrated alongside #114 with one change: I routed the indent/outdent replacement through Verified in a browser: collapsed Tab escapes the editor, selection Tab/Shift+Tab indents with the selection preserved, Thank you! Closing manually since it landed via a rebuilt combined commit rather than a direct GitHub merge. |
panphora
added a commit
that referenced
this pull request
Jun 19, 2026
…JSON, Safari fix Bundles several community fixes and features into one minor release. Added: - transformLinkUrl option for the link tooltip (#85) - Tab/Shift+Tab indent on selection, Cmd/Ctrl+] and Cmd/Ctrl+[ shortcuts, and public indentSelection()/outdentSelection() (#115) - JSON-aware data-ot-* parsing and data-ot-textarea-* shortcuts so textareaProps (e.g. required) works from HTML (#112) - Autocomplete recipe for @mention/#issue popups in docs/AUTOCOMPLETE.md (#96) Fixed: - Keyboard focus trap: collapsed Tab/Shift+Tab now uses native focus traversal so keyboard users can leave the editor, WCAG 2.1.2 (#113) - Toolbar accessibility following the W3C APG Toolbar pattern: roving tabindex, aria-pressed on toggle buttons only, aria-controls, menu-button semantics (#114) - Safari: re-flow the textarea after edits so caret/wrap stop desyncing from the overlay (#116) - exports.browser pointed to a non-existent file (overtype.iife.min.js); now overtype.min.js - Link tooltip sanitizes the URL before opening, closing a latent javascript: vector dist/ rebuilt from source. Full test suite passes, including the new keyboard-accessibility and toolbar a11y suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113
Tab/Shift+Tabnow fall through to native focus behavior, while selected text still indents/outdents.indentSelection()/outdentSelection()line transforms, using two spaces andsetRangeText(..., 'preserve').Ctrl/Cmd+]andCtrl/Cmd+[to shortcuts.inert/aria-hiddensyncingSummary by cubic
Stop trapping focus on Tab: collapsed Tab/Shift+Tab now move focus while selections still indent/outdent (Fixes #113). Also adds indent/outdent shortcuts and improves preview accessibility.
New Features
Bug Fixes
Written for commit a554161. Summary will update on new commits.