Fix task-list visual alignment for spaced checkbox markers#109
Closed
dannyvink wants to merge 1 commit into
Closed
Fix task-list visual alignment for spaced checkbox markers#109dannyvink wants to merge 1 commit into
dannyvink wants to merge 1 commit into
Conversation
dannyvink
force-pushed
the
fix-checkbox-spacing-alignment
branch
from
April 7, 2026 18:08
01e8fb3 to
1ad78e8
Compare
dannyvink
changed the title
panphora
pushed a commit
that referenced
this pull request
May 2, 2026
Markdown task list parsing only handled exactly one space around `[ ]`, so `- [ ] task` (two spaces) or empty `- [ ] ` lines rendered with normalized spacing that didn't match the textarea, breaking the overlay's character-perfect alignment. Update the regex to capture spacing before and after the checkbox separately and re-emit it verbatim, and allow empty content so the preview doesn't switch parsing modes the moment the user types the first character. Co-authored-by: Danny Vink <danny.vink@reddit.com>
Owner
|
Merged in 82aad33 via cherry-pick (rebuilt dist/ locally rather than carrying it in the merge). Original commit and authorship by @dannyvink preserved. Thanks for catching this — the alignment is fragile around whitespace and the regex change is the right surgical fix. Will ship in the next release. |
panphora
added a commit
that referenced
this pull request
May 2, 2026
Owner
|
Shipped in v2.3.7 (commit 82aad33). The regex in Thanks @dannyvink for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a visual issue around checkboxes.
- [ ](one space) and- [ ](two spaces) differently, with the latter breaking the virtual overlay.Changes
- [ ])Test plan
npm testnpm run build- [ ] Task,- [ ], and- [ ] Task