You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the auto-generated PR summary is collapsed into the walkthrough. I'd like to configure it like it was before, that it is represented by a full dedicated comment.
Details
📝 Walkthrough
Summary by CodeRabbit
New Features
Added support for ingesting XLSX files from local filesystems and cloud blob sources.
XLSX is now recognized as a supported file format in endpoint selection and format messaging.
Excel sheets can now be read and converted into rows for downstream processing.
Tests
Added coverage for Excel ingestion and updated existing checks to reflect the expanded supported formats.
Walkthrough
This PR adds XLSX file format support to the filesystem connector. It introduces a _read_excel reader using polars, a read_excel standalone transformer, and dispatch logic in resource_for_reader. The table argument is threaded through blobstorage and filesystem source APIs as sheet_name. The xlsx format is registered in FORMAT_TO_READER, new dependencies (fastexcel, polars) are added, and tests plus changelog entries are updated accordingly.
Changes
XLSX Reader Support
Layer / File(s)
Summary
Excel reader implementation and adapter dispatch omniload/source/filesystem/readers.py, omniload/source/filesystem/adapter.py
Adds _read_excel helper reading XLSX via polars, exposes read_excel standalone transformer, and extends resource_for_reader to special-case read_excel by passing table as sheet_name.
Table argument wiring through source APIs omniload/source/blobstorage/api.py, omniload/source/filesystem/api.py, tests/main/test_file_source.py
GCSSource, S3Source, and LocalFilesystemSource now pass table into resource_for_reader; test stub updated to capture the new argument.
Format registration, dependencies, and validation omniload/util/endpoint.py, pyproject.toml, tests/main/test_blob.py, tests/warehouse/storage/test_excel.py, docs/changelog.md
Registers xlsx → read_excel mapping, adds fastexcel/polars dependencies, adds an ingestion test for Excel, updates supported-format message test, and adds a changelog entry.
About
Currently, the auto-generated PR summary is collapsed into the walkthrough. I'd like to configure it like it was before, that it is represented by a full dedicated comment.
Details
📝 Walkthrough
Summary by CodeRabbit
New Features
Tests
Walkthrough
This PR adds XLSX file format support to the filesystem connector. It introduces a
_read_excelreader using polars, aread_excelstandalone transformer, and dispatch logic inresource_for_reader. Thetableargument is threaded through blobstorage and filesystem source APIs assheet_name. Thexlsxformat is registered inFORMAT_TO_READER, new dependencies (fastexcel,polars) are added, and tests plus changelog entries are updated accordingly.Changes
XLSX Reader Support
omniload/source/filesystem/readers.py,omniload/source/filesystem/adapter.py_read_excelhelper reading XLSX via polars, exposesread_excelstandalone transformer, and extendsresource_for_readerto special-caseread_excelby passingtableassheet_name.omniload/source/blobstorage/api.py,omniload/source/filesystem/api.py,tests/main/test_file_source.pyGCSSource,S3Source, andLocalFilesystemSourcenow passtableintoresource_for_reader; test stub updated to capture the new argument.omniload/util/endpoint.py,pyproject.toml,tests/main/test_blob.py,tests/warehouse/storage/test_excel.py,docs/changelog.mdxlsx→read_excelmapping, addsfastexcel/polarsdependencies, adds an ingestion test for Excel, updates supported-format message test, and adds a changelog entry.Estimated code review effort: 2 (Simple) | ~15 minutes
Sequence Diagram(s)
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
✨ Finishing Touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
excelThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment
@coderabbitai helpto get the list of available commands.Originally posted by @coderabbitai[bot] in #123 (comment)