Skip to content

Fix/soft deleting schema subjects #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix/soft deleting schema subjects #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab952df
fix: soft-deleting schema subject when finalizing custom resource
Mar 6, 2024
749dc88
fix: syntax errors in deployment.yaml
Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions controllers/kafkaschema_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,8 @@ func generateSchemaDeletionUrl(subject string) (string, error) {
url.WriteString(schemaRegistryHost)
url.WriteString(":")
url.WriteString(schemaRegistryPort)
url.WriteString("/config/")
url.WriteString("/subjects/")
url.WriteString(subject)
url.WriteString("?permanent=true")

return url.String(), nil
}
Expand Down
6 changes: 3 additions & 3 deletions kubernetes/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
labels:
{{- include "kubernetes.selectorLabels" . | nindent 8 }}
spec:
serviceAccountName: "{{ .Release.Name }}-service-account"
serviceAccountName: "{{ .Release.Name }}-service-account"
containers:
- name: {{ .Release.Name}}
image: "{{ .Values.operator.image }}:{{ .Values.operator.version }}"
Expand All @@ -26,9 +26,9 @@ spec:
- name: SCHEMA_REGISTRY_PORT
value: "{{ .Values.schemaRegistry.port }}"
- name: SCHEMA_REGISTRY_KEY
value: {{ .Values.schemaRegistry.key }}
value: {{ .Values.schemaRegistry.apiKey }}
- name: SCHEMA_REGISTRY_SECRET
value: {{ .Values.schemaRegistry.secret }}
value: {{ .Values.schemaRegistry.apiSecret }}
ports:
- name: http
containerPort: 65532
Expand Down