Skip to content

Adding support for oddly placed comments #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Conversation

amadeus
Copy link
Collaborator

@amadeus amadeus commented Jul 11, 2016

I have added support for a few basic comment positions. So far this is not really meant to be an exhaustive list of all possibilities, but really the most common patterns, and we can continue to add other comment patterns as people raise issues for them.

Here is a small snippet showing the ones that have been fixed.

class Durp /**/ {
}

class Durp // durp
{
}

class Durp extends Tube // durp
{
}

function testFunc() /**/ {
}

function testFunc() // durp
{
}

if (true) // asdlkfjas d
{
  var durp = 2;
} else /* durp */
{
  var durp = 4;
}

while (true)  // durp
{
  var durp = 2
}

for () /* durp */
{
  var durp = 2;
}

* Functions
* Classes
* Conditionals
* Repeat statements
@amadeus
Copy link
Collaborator Author

amadeus commented Jul 11, 2016

This should fix #487

@amadeus amadeus merged commit 4a6376a into develop Jul 11, 2016
@amadeus amadeus deleted the fix-oddly-placed-comments branch July 11, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant