Skip to content

limiting for slow function and operator fix #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2016
Merged

Conversation

bounceme
Copy link
Collaborator

@bounceme bounceme commented Jun 1, 2016

var magicWords = ['abracadabra', 'gesundheit', 'ventrilo'],
  spells = {
    'fireball': function() {
      setOnFire()
    },
    'water': function() {
      putOut()
    }
  },
  a = 1,
  b = 'abc',
  etc, somethingElse
someFunc(param1, param2,
  param3, param4)

at the line which starts with a curly brace followed by a comma this was needed for traversing the comma less property lines, however this only needs to be called once.this improves performance when using the endline operator style

```
var magicWords = ['abracadabra', 'gesundheit', 'ventrilo'],
  spells = {
    'fireball': function() {
      setOnFire()
    },
    'water': function() {
      putOut()
    }
  },
  a = 1,
  b = 'abc',
  etc, somethingElse
someFunc(param1, param2,
  param3, param4)
```
at the line which starts with a curly brace followed by a comment this was added for traversing the comma less property lines, however this only needs to be called once.this improves performance when using the endline operator style
@bounceme
Copy link
Collaborator Author

bounceme commented Jun 1, 2016

this is one of the really confusing parts about the indenter

@bounceme
Copy link
Collaborator Author

bounceme commented Jun 2, 2016

i think this is good enough for a merge to dev

bounceme added 2 commits June 1, 2016 23:57
an operator would previously  create an unnecessary indent when following a line which was the first of a list of block enclosed items, e.g. a array, function call, or object
before:
```
      vardefaultModules = {
        'http:': http
          ,'https:': https
      }
```
after:
```
      vardefaultModules = {
        'http:': http
        ,'https:': https
      }
```
@bounceme bounceme changed the title prevent repeated calls of searchpair limiting for slow function and operator fix Jun 2, 2016
@bounceme bounceme merged commit d6e174b into develop Jun 2, 2016
@bounceme bounceme deleted the bounceme-patch-1 branch June 2, 2016 16:38
amadeus pushed a commit that referenced this pull request Jun 14, 2016
* prevent repeated calls of searchpair

```
var magicWords = ['abracadabra', 'gesundheit', 'ventrilo'],
  spells = {
    'fireball': function() {
      setOnFire()
    },
    'water': function() {
      putOut()
    }
  },
  a = 1,
  b = 'abc',
  etc, somethingElse
someFunc(param1, param2,
  param3, param4)
```
at the line which starts with a curly brace followed by a comment this was added for traversing the comma less property lines, however this only needs to be called once.this improves performance when using the endline operator style

an operator would previously  create an unnecessary indent when following a line which was the first of a list of block enclosed items, e.g. a array, function call, or object
before:
```
      vardefaultModules = {
        'http:': http
          ,'https:': https
      }
```
after:
```
      vardefaultModules = {
        'http:': http
        ,'https:': https
      }
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant