Skip to content

misc fixes #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2016
Merged

misc fixes #404

merged 1 commit into from
Apr 28, 2016

Conversation

bounceme
Copy link
Collaborator

I'll test this some more and get some examples showing the new parts

@bounceme
Copy link
Collaborator Author

one()
  .then(two)
  .then(function() {
    console.log("value");
  })
foo(a(b,
      c))

var protocol = self.proxy && !self.tunnel ? self.proxy.protocol : self.uri.protocol,
  defaultModules = {
    'http:': http,
    'https:': https
  },
  httpModules = self.httpModules || {}

self.httpModule = httpModules[protocol] || defaultModules[protocol]

This mostly just fixes a few odd kinds of behavior with the logic of chaining operators and commas. I've done a good amount of testing and saw no problems with perf or regressions

@davidchambers
Copy link
Collaborator

This mostly just fixes a few odd kinds of behavior with the logic of chaining operators and commas.

Sounds good!

@bounceme
Copy link
Collaborator Author

I think this is merge-able. we can always revert if we need too

@bounceme bounceme merged commit e60e4eb into develop Apr 28, 2016
@amadeus amadeus deleted the misc.fixes branch April 29, 2016 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants