Skip to content

Custom jsFuncName for object definitions #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Conversation

amadeus
Copy link
Collaborator

@amadeus amadeus commented Apr 27, 2016

This ES6 version of jsFuncName requires some special handling to not, by default, overwrite jsObjectKey and also not overwrite jsFuncCall.

This should fix #261

I also fixed a bug in generator syntax matching within ES6 classes.

@amadeus amadeus force-pushed the fix-261 branch 2 times, most recently from d75b010 to b2907d6 Compare April 27, 2016 04:31
@amadeus
Copy link
Collaborator Author

amadeus commented Apr 27, 2016

Still need to figure out some issues when using a generators asterisk, so plz do not merge yet

Ok, I think I've got it figured out. Using this snippet as a nice test case:

var ob = {
    func2(){
    },
    test1: 2 * test16(),
    math: 2 + test2(),
    something: (2 + test3()),
    test2: {},
    test3: function *test(){},
    durp: test15(),
    *func(){},
    test4: test16(),
    arr: [
        function Name(){},
        test3()
    ],

    flurp(){
    }
};


var test17 = function(){};
var test18 = function *Named(){};

function *Test18() {}
function Test19(){}

example

This ES6 version of jsFuncName requires some special handling to not, by
default, overwrite jsObjectKey and also not overwrite jsFuncCall.
@amadeus amadeus merged commit 187594a into pangloss:develop Apr 27, 2016
@amadeus amadeus deleted the fix-261 branch April 27, 2016 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant