Improvements to rest highlighting #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myFunction(...iterableObj) // spreadfunction(a, b, ...theArgs) { // rest
// ...
}To which of the parenthesized sections above does |
|
You're correct, I misread the spec, I'll rename them back, fix up this PR shortly. |
amadeus
force-pushed
the
update-spread-matching
branch
from
3923f9e to
bfe2920
Compare
amadeus
changed the title
amadeus
force-pushed
the
update-spread-matching
branch
from
bfe2920 to
defad41
Compare
|
Fixed. |
amadeus
force-pushed
the
update-spread-matching
branch
from
defad41 to
aac12e4
Compare
| @@ -219,7 +219,8 @@ syntax match jsGenerator contained '\*' nextgroup=jsFuncName skipwhite | |||
| syntax match jsFuncName contained /\<[a-zA-Z_$][0-9a-zA-Z_$]*/ nextgroup=jsFuncArgs skipwhite | |||
| syntax region jsFuncArgs contained matchgroup=jsFuncParens start='(' end=')' contains=jsFuncArgCommas,jsFuncArgRest,jsAssignmentExpr,jsComment,jsLineComment nextgroup=jsFuncBlock keepend skipwhite skipempty | |||
| syntax match jsFuncArgCommas contained ',' | |||
| syntax match jsFuncArgRest contained /\%(\.\.\.[a-zA-Z_$][0-9a-zA-Z_$]*\))/ | |||
| syntax match jsFuncArgRest contained /\%(\.\.\.[a-zA-Z_$][0-9a-zA-Z_$]*\))/ contains=jsFuncArgRestDots | |||
There was a problem hiding this comment.
Sorry, not sure what you mean?
There was a problem hiding this comment.
Nevermind, you meant whitespace alignment, fixed
* Added higher specificity to the dots in the spread declaration
amadeus
force-pushed
the
update-spread-matching
branch
from
aac12e4 to
7323233
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noise