Skip to content

Fix nested template variable syntax highlighting #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Fix nested template variable syntax highlighting #342

merged 1 commit into from
Feb 22, 2016

Conversation

kfahy
Copy link
Contributor

@kfahy kfahy commented Jan 9, 2016

Accept JS expressions in template variables so that their contents are
highlighted normally. Change jsTemplateVar to a region rather than
a match.

Fixes #316


Before:
js_syntax_-_before

After:
js_syntax_-_after

Accept JS expressions in template variables so that their contents are
highlighted normally. Change `jsTemplateVar` to a region rather than
a match.

Fixes #316
@davidchambers
Copy link
Collaborator

LGTM

qstrahl added a commit that referenced this pull request Feb 22, 2016
Fix nested template variable syntax highlighting
@qstrahl qstrahl merged commit f099955 into pangloss:develop Feb 22, 2016
@qstrahl
Copy link
Collaborator

qstrahl commented Feb 22, 2016

Overdue for a merge... making this happen.

@kfahy kfahy deleted the bug-nested-template-strings branch February 22, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants