fix GH-247: Single-line comments after import statement #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single line comment in the following statement is currently no highlighted: ```js import Y from 'Y' // this should be a comment ``` This introduces jsLineComment as being containable in an import statement, and also closes the import statement on semicolon so that other expressions can be highlighted correctly.
|
Fixes GH-247 |
|
Seems harmless |
qstrahl
added a commit
that referenced
this pull request
Jul 17, 2015
fix GH-247: Single-line comments after import statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single line comment in the following statement is currently no
highlighted:
This introduces jsLineComment as being containable in an import statement,
and also closes the import statement on semicolon so that other expressions
can be highlighted correctly.