fix: export region should support es6 class and block openings #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the following syntax results in an error on the closing
brace:
```js
export default {
} // <-- error here
export default class Modules extends Base {
} // <-- error here
```
This patch adds jsBlock to be included in a jsExportContainer region
so that region matching will continue to the end of the class or block.
|
This commit fixes issue GH-256 |
|
Let's give this a shot |
qstrahl
added a commit
that referenced
this pull request
Jul 17, 2015
fix: export region should support es6 class and block openings
|
I remember this breaking certain things, lets give it a whirl now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following syntax results in an error on the closing
brace:
This patch adds jsBlock to be included in a jsExportContainer region
so that region matching will continue to the end of the class or block.