Skip to content

Fix for #34 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2015
Merged

Fix for #34 #238

merged 1 commit into from
Jan 29, 2015

Conversation

dragn
Copy link
Contributor

@dragn dragn commented Jan 29, 2015

Fix for #34
Regex modified to detect lines, ended with comma and containing single = (equals) character (not double or triple to avoid match on conditionals).
May break things if you do assignments in weird places, for example:

A = {
    B : (C = D),
        E : F,
};

@davidchambers
Copy link
Collaborator

LGTM. Could you squash the commits?

@dragn
Copy link
Contributor Author

dragn commented Jan 29, 2015

Done

goatslacker added a commit that referenced this pull request Jan 29, 2015
@goatslacker goatslacker merged commit 27f16d5 into pangloss:develop Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants