Regular expressions /\[/ and /\]/ break syntax highlighting

[moll]

For example:

.replace(/\[/g, ".").replace(/\]/g, "")

Results in the following redness:

[amadeus]

Based on the screenshot and some testing, I think I can assume you are using Vim 7.4?

If that's the case, regexes are completely broken right now in 7.4, and I am actively looking for a fix.

[moll]

Yep, Vim v7.4.

But Vim 7.4 breaks regexps? That's.. weird. Have some semantics of regexpes changed with the supposed new engine?

[qstrahl]

It probably has to do with the super special \@ family of regex directives -- something that doesn't come up often.

[amadeus]

A temporary fix for now, until we get this sorted:

:set regexpengine=1
:syntax enable

This will (for that session) force the use of the old regex engine where this bug doesn't exist.

[qstrahl]

Is that a confirmed fix?

[amadeus]

This will fix regexes to actually be detected properly (as they where in 7.3). I don't see it as a fix though, I think we still need to get at the root of WHY it breaks in 7.4. Also, I would assume setting regexengine in a syntax file would be a poor solution to the problem.

I agree with one of your other comments, in that it probably has something to do with @ assertions.

The following works in both 7.4 and 7.3:

return /someregex/i

but this only works in 7.3

var reg = /someregex/i;

Setting the regexpengine to 1 gets both of those cases working in 7.4. I will continue to explore these further.

[amadeus]

Here's a link to thread I've started on the vim_dev mailing list. It's really looking like this is a bug in the regex parser:

https://groups.google.com/forum/#!topic/vim_dev/Edrh9FODMvA

[qstrahl]

We definitely shouldn't set regexengine in the syntax file. It's nice to know there's a workaround, though. If changing the value of regexengine changes the syntax highlighting at all, then it's pretty much definitely an issue with Vim and not with this plugin specifically.

[amadeus]

As I mentioned in #88 👍

I am happy to report that the latest version of Vim, 7.4 with patches 1-7 appears to fix this issue.

You can run a :version to check what version you are on.

I am closing this issue now, let me know if you can't confirm a fix with the aforementioned version and I will re-open.

For more information: https://groups.google.com/forum/#!topic/vim_dev/GfSwrDEAejM