Regular expression and quote (/"/) breaks syntax highlighting

[Rob--W]

Steps to reproduce:

var x = /"/;
var y = '';

Output:

Expected output (colors are different, but at least the highlighting is consistent):

[amadeus]

I've done a bit of poking around, and it appears as if Regexes are entirely broken in this plugin as it stands.

I may need to perform a git bisect to figure out when this got broken.

[amadeus]

Based on a quick git bisect it looks like this commit broke regex matching:

ed58aec

[mwcz]

Nice work! I just ran into this today and glanced at the syntax file to see if I could fix it. Turns out (yet again) that I don't understand vim syntax files for crap.

I applied the change you suggested manually and it worked perfectly. I am not sure if there are any regressions associated with that change, though. I just know that regexes work now.

[amadeus]

So after more research, it appears this issue is really just isolated to Vim 7.4.

A temporary fix for now, until we get this properly sorted, just run these commands after you load a JS file:

:set regexpengine=1
:syntax enable

This will (for that session) force the use of the old regex engine where this bug doesn't exist. Of course you will have to do this every time.

[amadeus]

I am happy to report that the latest version of Vim, 7.4 with patches 1-7 appears to fix this issue.

You can run a :version to check what version you are on.

I am closing this issue now, let me know if you can't confirm a fix with the aforementioned version and I will re-open.

For more information: https://groups.google.com/forum/#!topic/vim_dev/GfSwrDEAejM

[lasseebert]

I'm still seeing this issue on the latest version of Vim (VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Aug 12 2013 00:23:33))

It seems to only affect double qoutes, e.g. /"/ and not /\[/

The tip about

:set regexpengine=1
:syntax enable

fixes it. Could it break anything else to just include it in my vim config?

[amadeus]

@lasseebert what patches do you have on 7.4? You must have at least patches 1-7.

And to answer your other question, setting the regexpengine to 1 simply puts the regex engine back to what it had in vim 7.3. Not bad per se, but you won't get any of its newer optimizations.

[lasseebert]

Oh yes, my mistake. Building with patches solves it. Thanks.