Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

send to pangloss #3

Merged
merged 39 commits into from
Jun 15, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
628774e
- Access georss point information for photos
amuino Nov 30, 2009
280d98b
add initialization code to the plugin
amuino Dec 1, 2009
1d881bf
Properly name the initialization file.
amuino Dec 1, 2009
ee8a088
Updated installation instructions (install locally on a rails project)
amuino Dec 1, 2009
8593c75
Allows parsing some search results which do not have a <category> for…
amuino Dec 1, 2009
2ac8e40
Test two edge cases causing problems and add a fix (fix for one of th…
amuino Dec 1, 2009
73a938a
ignore .svn folders
amuino Dec 1, 2009
15c453a
fix dependency on objectify_xml so that rake gems:install does not fail
amuino Dec 3, 2009
7525196
Added gphoto:user element to the User object.
kueda Dec 21, 2009
e85ec5e
Added a License subclass to Photo.
kueda Dec 22, 2009
35de652
Added nickname, user + nickname to photo, and updated sizes.
kueda Dec 24, 2009
66336f3
Added user and nickname attributes to the Author object.
kueda Dec 28, 2009
5e21d6b
Added location attr to photo.
kueda Dec 28, 2009
c94e9f0
Added timestamp attr to Photo.
kueda Dec 28, 2009
87c8109
Fixed bug when Picasa photos had comments.
kueda Dec 29, 2009
25a82bf
update picture resolution values
Nov 11, 2010
1cab293
Merge branch 'master' of github.com:fjg/ruby_picasa
Nov 11, 2010
9f3cdeb
Revert "update picture resolution values"
Nov 11, 2010
7fb9ff2
add gemspec support and new thumbnail size
Nov 11, 2010
ef70e14
add new thumbnail sizes
Nov 11, 2010
e22343a
fix google AuthSubSessionToken url
Mar 5, 2011
e1ccbd5
Add token validation method
mfo Jan 22, 2013
119568c
on check authsubtoken - cast response.status to string for better com…
mfo Jan 22, 2013
0fd01ba
add PicasaTokenRevokedError
mfo Jan 22, 2013
3dbdd21
change valid_token from class method to instance method
mfo Jan 22, 2013
a435ed9
move method valid_token
mfo Jan 22, 2013
152f313
update signature
mfo Jan 22, 2013
bc0dfe9
rename method
mfo Jan 22, 2013
693859f
update code
mfo Jan 22, 2013
c4a3d53
feat(tech): bump to ruby 2.2.1
May 12, 2015
026e20c
fix(dependencies): add active support to dependencies list because ob…
May 12, 2015
9c27804
tech(spec): bump to rspec 3.2.3. Start fixing types_spec: User, Recen…
May 12, 2015
8b9f515
tech(spec): Fix Search, Class from XML [deprecated ruby starts_with]
May 12, 2015
ac0fdad
fix(spec): ruby_picasa_spec by updating matching
May 12, 2015
aebc65a
tech(rspec): use new convension for .rspec default opts
May 12, 2015
6bfab27
tech(devnotes): start specing
May 12, 2015
0afa288
feat(oauth2): switch authentication method from authsub to oauth2
May 18, 2015
e1b1e17
merge(US/oauth2): production rdy
May 18, 2015
87a8157
release(0.2.4): bump version
May 18, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed bug when Picasa photos had comments.
Note that I broke a spec concerning how class_from_xml responds to invalid
feed types, though I'm not sure why it worked in the first place. If there are
any rspec gurus reading, I'd appreciate some input.
  • Loading branch information
kueda committed Dec 29, 2009
commit 87c81096ce60259c3102e102cfba9cfabd9fde1d
9 changes: 3 additions & 6 deletions lib/ruby_picasa.rb
Original file line number Diff line number Diff line change
Expand Up @@ -351,19 +351,16 @@ def class_from_xml(xml)
RubyPicasa::User.new(xml, self)
when /#photo$/
RubyPicasa::RecentPhotos.new(xml, self)
when nil
else
RubyPicasa::Search.new(xml, self)
end
when /#album$/
case entry_scheme
when nil, /#photo$/
RubyPicasa::Album.new(xml, self)
end
RubyPicasa::Album.new(xml, self)
when /#photo$/
case entry_scheme
when /#photo$/
RubyPicasa::Search.new(xml, self)
when nil
else
if feed_href && (feed_href.starts_with? 'http://picasaweb.google.com/data/feed/api/all')
RubyPicasa::Search.new(xml, self)
else
Expand Down
5 changes: 4 additions & 1 deletion spec/ruby_picasa_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,10 @@ def to_create(klass, feed, entry)
it('photo nil') { to_create RubyPicasa::Photo, @photo, nil }
it('photo photo') { to_create RubyPicasa::Search, @photo, @photo }
end


# I broke this test, though I'm not sure how to fix it (or why it ever
# worked to begin with). Shouldn't it always break when you pass in a
# symbol instead of actual xml? -- kueda 2009-12-29
it 'should raise an error for invalid feed category types' do
@p.expects(:xml_data).with(:xml).returns([:xml, @album, @user])
lambda do
Expand Down