Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rechunk to accept a Dask array #27

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

tomwhite
Copy link
Collaborator

Addresses #21.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #27 into master will increase coverage by 1.35%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   88.94%   90.30%   +1.35%     
==========================================
  Files           2        2              
  Lines         190      196       +6     
  Branches       44       45       +1     
==========================================
+ Hits          169      177       +8     
+ Misses         11       10       -1     
+ Partials       10        9       -1     
Impacted Files Coverage Δ
rechunker/api.py 93.12% <81.81%> (+0.32%) ⬆️
rechunker/algorithm.py 84.61% <0.00%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdddf0f...93f9b59. Read the comment docs.

@rabernat
Copy link
Member

This is perfect @tomwhite. Thanks so much for your contribution!

I'd like to start keeping track of things in https://github.com/pangeo-data/rechunker/blob/master/docs/release_notes.rst. Could you just add a bullet about this new feature? Then we are good to merge.

@tomwhite
Copy link
Collaborator Author

Thanks @rabernat! Updated the release notes.

@rabernat
Copy link
Member

I'll merge this. I'd like to disable the codecov/patch check as I don't think it's helpful.

Thanks @tomwhite!

@rabernat rabernat merged commit 23a3492 into pangeo-data:master Jul 21, 2020
@tomwhite tomwhite deleted the rechunk-dask-array branch July 21, 2020 20:26
@rabernat rabernat mentioned this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants