-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isin
on asi8
instead of cftime
#724
Conversation
Performance report: on
on
|
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 93.80% 93.35% -0.46%
==========================================
Files 59 59
Lines 6235 6263 +28
==========================================
- Hits 5849 5847 -2
- Misses 386 416 +30
Continue to review full report at Codecov.
|
Description
xr.DataArray.coords['init'].isin(xr.DataArray.coords['time'])
is slowisin
onxr.CFTimeIndex
-backedxr.DataArray
but after converting to index andasi8
(e.g. 'ms since 1970')Closes #414
Type of change
asv
to detect performance changes)How Has This Been Tested?
pytest
, if necessary.Checklist (while developing)