Document jsoneditor extension requirement for ReactFlow#39
Conversation
…ow.__init__ Co-authored-by: MarcSkovMadsen <42288570+MarcSkovMadsen@users.noreply.github.com>
Co-authored-by: MarcSkovMadsen <42288570+MarcSkovMadsen@users.noreply.github.com>
Co-authored-by: MarcSkovMadsen <42288570+MarcSkovMadsen@users.noreply.github.com>
Co-authored-by: MarcSkovMadsen <42288570+MarcSkovMadsen@users.noreply.github.com>
…ension-warning review feedback
MarcSkovMadsen
left a comment
There was a problem hiding this comment.
Please note I've reviewed and tested. The copilot proposed import of "jsoneditor" does not work. And I cannot find any other working code.
Please instead document in docs that the user needs to run pn.extension("jsoneditor") when the JSONEditor is available for usage. Please also update any relevant code examples in the documentation.
|
@copilot. Please rerun the failing ui tests. Fix if there are errors. |
Co-authored-by: MarcSkovMadsen <42288570+MarcSkovMadsen@users.noreply.github.com>
I've updated the documentation as requested. The auto-loading approach has been removed (you already reverted it in d86ae04), and I've now:
Changes committed in 4a38089. |
Co-authored-by: MarcSkovMadsen <42288570+MarcSkovMadsen@users.noreply.github.com>
I've fixed the UI test file to load the jsoneditor extension. The test was using Changed in commit 73f2bf1:
The UI tests should now run without the jsoneditor extension warning when the CI rebuilds. |
Fixed UI Test Extension Loading
Updated
tests/ui/test_ui.pyto callpn.extension("jsoneditor")instead of plainpn.extension(). This ensures the jsoneditor extension is loaded before creating ReactFlow instances in tests, preventing the warning:Changes
pn.extension()topn.extension("jsoneditor")This aligns the test file with the documentation updates and ensures consistent extension loading across the codebase.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.