BUG: Series.map fails when keys are tuples of different lengths (#7333) #7336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| df['labels'] = df['a'].map(label_mappings) | ||
| # All labels should be filled now | ||
| self.assertFalse(any(df['labels'].isnull())) |
There was a problem hiding this comment.
explicitly construct the Series that you want and compare the result with the expected using tm.assert_series_equal(result, expected).
|
this seems like a bug in the |
|
probably related to the change to use multiindex for tuple keys by default |
|
hm nevermind ... i guess the constructor behavior makes sense from a mi point of view |
|
pls add a release note to |
Explicitly use keys as index to prevent conversion to MultiIndex Add test for mapping with tuple-keyed dict Specify expected output for the test and use assert_series_equal Add note to v0.14.1 release notes
|
Alright, I've added to the release notes and it seems like everything's good, so I've squashed into a single commit. Should be okay to merge if people are OK with it. |
jreback
changed the title
Series.map fails when keys are tuples of different lengths (#7333)
|
@cpcloud looks ok to you? (i'll clear conflict on merging) |
|
Yep. |
|
@onesandzeroes thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7333 seems to be due to the new behaviour of
Series, which will automatically create a MultiIndex out of the dict's keys when creating a series to map the values. The MultiIndex doesn't match the values for the shorter tuples, so they fail to map.The fix is fairly simple, just pass the dict keys explicitly as the index.
I've added a test case for this specific issue, but could add some more if others can see related issues that would arise from this. I'll try to finalize the PR (squashing into a single commit, rebasing if necessary) tomorrow if it looks good.