CLN: Make offsets.BusinessHour.next_bday private#64715
Merged
mroeschke merged 3 commits intopandas-dev:mainfrom Mar 20, 2026
Merged
Conversation
pandas/_libs/tslibs/offsets.pyx
Outdated
| >>> pd.offsets.CustomBusinessHour(-2).next_bday | ||
| <-1 * CustomBusinessDay> | ||
| >>> pd.offsets.BusinessHour(1).next_bday | ||
| <BusinessDay> |
Member
There was a problem hiding this comment.
I don’t think this is all necessary. What if we just made the method private?
Contributor
Author
There was a problem hiding this comment.
I've renamed it to _next_bday and reverted the docstring to the short form. The state.pop("next_bday", None) in __setstate__ is kept as-is for backward-compatible unpickling.
tuhinsharma121
changed the title
mroeschke
approved these changes
Mar 20, 2026
Member
|
Thanks @tuhinsharma121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BusinessHour.next_bdayto_next_bdaysince it is only used internally within the class and was never part of the public API.state.pop("next_bday", None)in__setstate__is preserved for backward-compatible unpickling.Test plan
next_bdayexists in tests or docs)