DEPR: Categorical with values not present in categories #62142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Aug 20, 2025
pandas/core/arrays/categorical.py
Outdated
Comment on lines
545
to
550
| warnings.filterwarnings( | ||
| "ignore", | ||
| "Constructing a Categorical with a dtype and values", | ||
| FutureWarning, | ||
| ) | ||
| res = cls._from_sequence(scalars, dtype=dtype) |
Member
There was a problem hiding this comment.
What happens here once the deprecation is enforced?
pandas/tests/dtypes/test_dtypes.py
Outdated
Comment on lines
131
to
132
| # [c, None, None, dtype2, dtype2], | ||
| # [c, ["x", "y"], False, None, dtype2], |
Member
Author
There was a problem hiding this comment.
good catch, will update
rhshadrach
requested changes
Sep 7, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Sorry, fell off my radar for a bit. Looks good, but will need to replace FutureWarning with Pandas4Warning throughout.
rhshadrach
added
Categorical
Member
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astypemethod fails to raise errors forcategorydata type #59899doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.